#22478: Wrong module name used in build_test
-----------------------------------+--------------------------------------
Reporter: anonymous | Owner: nobody
Type: Bug | Status: new
Component: Testing framework | Version: 1.7-beta-1
Severity: Normal | Resolution:
Keywords: tests, test suite | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by rtnpro):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I am able to reproduce the reported bug. I have also reviewed the patches
and tested it on my local codebase of Django running tag 1.7b1. The
patches seem to be working, however, they are not PEP8 compliant.
{{{
$ pep8 tests/test_suite_override/sample_app/
tests/test_suite_override/sample_app/__init__.py:1:24: W292 no newline at
end of file
tests/test_suite_override/sample_app/models.py:4:1: E302 expected 2 blank
lines, found 1
tests/test_suite_override/sample_app/tests/__init__.py:2:27: W292 no
newline at end of file
}}}
So, I'd suggest yakky to make the change PEP8 compliant and submit an
incremental patch.
I will mark this ticket as accepted. If someone has any point to add,
please feel free to share your opinion.
--
Ticket URL: <https://code.djangoproject.com/ticket/22478#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.606071405797b977bb1f427c15c35333%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
