#22489: Missing as_sql() implementation for __search lookup
-------------------------------------+-------------------------------------
     Reporter:  jakub                |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:  mysql, search,       |      Needs documentation:  0
  full-text, __search, lookup        |  Patch needs improvement:  0
    Has patch:  1                    |                    UI/UX:  0
  Needs tests:  1                    |
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by charettes):

 * needs_better_patch:   => 0
 * version:   => master
 * needs_docs:   => 0
 * needs_tests:   => 1
 * stage:  Unreviewed => Accepted


Comment:

 Could you add a regression test for this?

 Since it's only supported on MySQL atm you'll need to decorate your tests
 with `@skipUnless(connection.vendor == 'mysql')`. Since Mark is working on
 adding support for this to the postgresl backend we might want to add a
 database feature flag and rely on `skipUnlessDbFeature` instead.

 I guess those tests should live in `tests/lookup/tests.py`.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/22489#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.24d18ecfdaa3f6693da0d77ea02749b0%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to