#3214: [patch] raw sql file doesn't recognize quotes correctly
-------------------------------------+-------------------------------------
     Reporter:  shaunc <shaun@…>     |                    Owner:  nobody
         Type:  Bug                  |                   Status:  closed
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |               Resolution:  fixed
     Severity:  Release blocker      |             Triage Stage:  Ready for
     Keywords:  rawsql migrations    |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Aymeric Augustin <aymeric.augustin@…>):

 In [changeset:"3bb0f118ca375f25cd0c03a5733ee2ef9d79dfa5"]:
 {{{
 #!CommitTicketReference repository=""
 revision="3bb0f118ca375f25cd0c03a5733ee2ef9d79dfa5"
 [1.7.x] Fixed #3214 -- Stopped parsing SQL with regex.

 Avoided introducing a new regex-based SQL splitter in the migrations
 framework, before we're bound by backwards compatibility.

 Adapted this change to the legacy "initial SQL data" feature, even
 though it's already deprecated, in order to facilitate the transition
 to migrations.

 sqlparse becomes mandatory for RunSQL on some databases (all but
 PostgreSQL). There's no API to provide a single statement and tell
 Django not to attempt splitting. Since we have a more robust splitting
 implementation, that seems like a good tradeoff. It's easier to add a
 new keyword argument later if necessary than to remove one.

 Many people contributed to both tickets, thank you all, and especially
 Claude for the review.

 Refs #22401.

 Backport of 8b5b199 from master
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/3214#comment:52>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/086.ef35856c5cfd37619b5c0a2e4a799a59%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to