#19195: Using distinct([*fields]) filter on a foreign key produces an ordering error when the foreign key has a Meta ordering field. -------------------------------------+------------------------------------- Reporter: chrisedgemon@… | Owner: nobody Type: Bug | Status: new Component: Database layer | Version: 1.4 (models, ORM) | Resolution: Severity: Normal | Triage Stage: Accepted Keywords: distinct, query | Needs documentation: 0 Has patch: 0 | Patch needs improvement: 0 Needs tests: 0 | UI/UX: 0 Easy pickings: 0 | -------------------------------------+-------------------------------------
Comment (by akaariai): Yes, I think we should do this for 1.7. Some review comments: - The actual code changes look correct - Release notes and some documentation changes for order_by() needed The test changes looked a bit scary to me (do all existing tests continue to test what they originally tested?), but after a bit more reading I think they are safe. A final check here wouldn't hurt. -- Ticket URL: <https://code.djangoproject.com/ticket/19195#comment:8> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/080.391e2f7bb132abf4475dfa7c0872ff24%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.