#22510: Form fields cannot have names that are present as attributes on the form
---------------------------------+--------------------------------------
Reporter: gc@… | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 1.7-beta-2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+--------------------------------------
Comment (by loic84):
Allowing `MyForm().foo == MyForm['foo']` would require additional magic.
Fields defined declaratively are stored in `Form.declared_fields`, those
fields should be considered immutable, they are then cloned into
`Form.fields` in `Form.__init__` where they can be freely modified by form
instances. If we just stuck to python inheritance and didn't remove
fields, we'd expose a big footgun where altering `self.fieldname` would
alter the form globally. We could mitigate the problem by shadowing
declared fields by their clone in `__init__`, but that's just additional
magic, and it doesn't offer much benefit over `Form.fields`. All in all,
I'm -0 on this option.
--
Ticket URL: <https://code.djangoproject.com/ticket/22510#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/071.2018bc8812f1d1367773764e116efd27%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
