#21230: Remove usage of direct settings manipulation in Django's tests
--------------------------------------+------------------------------------
Reporter: akaariai | Owner: whoshuu
Type: Cleanup/optimization | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by whoshuu):
There is still a pull request that references this ticket
[https://github.com/django/django/pull/2525 here]. The outstanding issue
is whether `staticfiles_tests/project/site_media/static/testfile.txt` is
deleted after running the affected test code. Reviewing the history of
that file, it seems to be vestigial and can safely be removed from source
control. The pull request currently doesn't remove it itself, but it can.
It would be helpful if someone can take a look at this and decide if the
refactor is worth taking this additional step. Otherwise, I can close the
PR and unassign this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/21230#comment:23>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.b1e6d70140b153000601b5b1a7368835%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
