#7220: django.contrib.auth.models.AbstractBaseUser.last_login should allow
null=True
-------------------------------------+-------------------------------------
Reporter: veena | Owner: anonymous
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: contrib.auth | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: schemamigration | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by charettes):
Replying to [comment:13 timo]:
> 1. I think your suggestion is okay; PR updated with it.
The changes LGTM.
> 2. I added a data migration to the PR. I am not sure if it's a good
idea, especially because `User` is swappable. It may be better to put that
code in the release notes and ask them to run it if they'd like. For
testing, I would probably just test the function in the migration outside
of the migrations framework itself.
I won't strongly oppose to a mention in the release notes instead but it
should be pretty safe to rely on the `User` model if it's retrieved from
the provided `apps` based on the `AUTH_USER_MODEL` setting.
--
Ticket URL: <https://code.djangoproject.com/ticket/7220#comment:14>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.9978bc97be46a3b7e1bd2c69077ecc75%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
