#21160: in_bulk() fails on SQLite when passing more than 999 ids
-------------------------------------+-------------------------------------
Reporter: NiGhTTraX | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: in_bulk sqlite 999 | Needs documentation: 0
1000 | Patch needs improvement: 1
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_better_patch: 0 => 1
Comment:
Updated patch can be found from
https://github.com/django/django/pull/3046.
The usage of bulk_batch_size() is incorrect in the patch. The method is
documented to receive a list of objects, but for the use case in this
ticket it receives an iterable of field values. We can either change the
method definition so that it can receive either an iterable of field
values, or a list of objects. Or we can just add a new feature
"max_query_params" and use that instead.
I slightly prefer the approach of adding max_query_params in to database
features. Then we can make supports_1000_query_params to be a property
which is calculated based on max_query_params, and also make the base
bulk_batch_size() to use the max_query_params feature.
--
Ticket URL: <https://code.djangoproject.com/ticket/21160#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.b8cbc7e811692dcae760d3f4e337830f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
