#23295: ALLOWED_HOSTS setting is done in the wrong place, should be in a custom
middleware
-------------------------------+--------------------------------------
Reporter: mark0978 | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Comment (by carljm):
Replying to [comment:3 collinanderson]:
> Well, it doesn't break any tests to remove the " and request.get_host()"
check.
> https://github.com/django/django/pull/3072
Nice, seems fine to me. I think if we do that we should also add a test
verifying that `get_host` is never called by `fix_location_header` if the
location header is already a full URL; otherwise the motivating use case
here could regress without it being caught.
--
Ticket URL: <https://code.djangoproject.com/ticket/23295#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.ea7912bcad144dee049b304f2aa36c06%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
