#23679: varchar(255) converted into varchar(255) NOT NULL after inspectdb 
followed
by migrate
-------------------------------------+-------------------------------------
     Reporter:  paulcdejean          |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Core (Management     |                  Version:  1.7
  commands)                          |               Resolution:
     Severity:  Normal               |             Triage Stage:  Accepted
     Keywords:                       |      Needs documentation:  0
    Has patch:  0                    |  Patch needs improvement:  0
  Needs tests:  0                    |                    UI/UX:  0
Easy pickings:  0                    |
-------------------------------------+-------------------------------------
Changes (by claudep):

 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 The fact that `inspectdb` doesn't add `null=True` on
 `CharField`s/`TextField`s is based on a Django "good practice", explained
 in https://docs.djangoproject.com/en/stable/ref/models/fields/#null

 Now the question is, should `inspectdb` reflect the current database
 structure as faithfully as possible, or should it entice users to follow
 good practices? At a minimum, Django should add a comment that it has not
 respected the NULL flag on the introspected field. Accepted the ticket on
 that base.

--
Ticket URL: <https://code.djangoproject.com/ticket/23679#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.37fb9e1f9fea473a9128b07d334a613f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to