#23792: Random test failure of TestCookieStorage.test_reset_cookie
-------------------------------------+-------------------------------------
     Reporter:  tchaumeny            |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |                  Version:  master
    Component:  Uncategorized        |               Resolution:
     Severity:  Normal               |             Triage Stage:
     Keywords:                       |  Unreviewed
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by tchaumeny):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Old description:

> This test fails randomly, as seen in http://djangoci.com/job/django-pull-
> requests/1528/database=postgres,python=python3.4/testReport/junit/django.contrib.formtools.tests.wizard.test_cookiestorage/TestCookieStorage/test_reset_cookie/
>
> After some investigation, I can reproduce the failure by adding a
> `time.sleep(1)` after this line
> https://github.com/django/django/blob/88b2a20f047347da86f448fe09a56251d29e4168/django/core/signing.py#L183.
>
> I suggest the introduction of a context manager `freeze_time` to handle
> this issue (there is also a recurring pattern for that in Django test
> suite).

New description:

 This test fails randomly, as seen in http://djangoci.com/job/django-pull-
 
requests/1528/database=postgres,python=python3.4/testReport/junit/django.contrib.formtools.tests.wizard.test_cookiestorage/TestCookieStorage/test_reset_cookie/

 After some investigation, I can reproduce the failure by adding a
 `time.sleep(1)` after this line
 
https://github.com/django/django/blob/88b2a20f047347da86f448fe09a56251d29e4168/django/core/signing.py#L183.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/23792#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.3e24821144c5820d56d2d7049ed687c4%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to