#23879: We should use test-skipping, not conditional discovery in runtests.py
--------------------------------------+------------------------------------
     Reporter:  carljm                |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Testing framework     |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------

Comment (by prestontimmons):

 Carl,

 I think the discovery result is still the same as it was when the discover
 runner was merged. Claude's changes simply replaced the old `geo_apps`
 function:

 
https://github.com/django/django/commit/bd563f0f571e7c76b40e8c8d7a0e1f34dcfeb810
 
https://github.com/django/django/commit/57f190ed3b77eb105cc86ecfabc455662410d40a

 Using `discovery_paths` this way—to conditionally add test applications
 from contrib to INSTALLED_APPS—isn't really obvious from the code, though.

--
Ticket URL: <https://code.djangoproject.com/ticket/23879#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.fc6a70214bfb7c35629cca1530d2080e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to