#23788: Stop templatizing js files for gettext >= 0.18.3
--------------------------------------+------------------------------------
     Reporter:  claudep               |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Internationalization  |                  Version:  master
     Severity:  Release blocker       |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by timgraham):

 * status:  closed => new
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * severity:  Normal => Release blocker


Comment:

 Some tests are failing on Windows after this change.
 {{{
 ======================================================================
 ERROR: test_media_static_dirs_ignored
 (i18n.test_extraction.JavascriptExtractorTests)
 ----------------------------------------------------------------------
 Traceback (most recent call last):
   File "c:\users\tim\code\django\django\test\utils.py", line 275, in inner
     return test_func(*args, **kwargs)
   File "c:\Users\Tim\code\django\tests\i18n\test_extraction.py", line 376,
 in test_media_static_dirs_ignored
     _, po_contents = self._run_makemessages(domain='djangojs')
   File "c:\Users\Tim\code\django\tests\i18n\test_extraction.py", line 62,
 in _run_makemessages
     stdout=out, **options)
   File "c:\users\tim\code\django\django\core\management\__init__.py", line
 120,
 in call_command
     return command.execute(*args, **defaults)
   File "c:\users\tim\code\django\django\core\management\base.py", line
 442, in execute
     output = self.handle(*args, **options)
   File
 "c:\users\tim\code\django\django\core\management\commands\makemessages.py
 ", line 298, in handle
     potfiles = self.build_potfiles()
   File
 "c:\users\tim\code\django\django\core\management\commands\makemessages.py
 ", line 327, in build_potfiles
     f.process(self, self.domain)
   File
 "c:\users\tim\code\django\django\core\management\commands\makemessages.py
 ", line 68, in process
     is_templatized = command.gettext_version < (0, 18, 3)
   File "c:\users\tim\code\django\django\utils\functional.py", line 60, in
 __get_
     res = instance.__dict__[self.name] = self.func(instance)
   File
 "c:\users\tim\code\django\django\core\management\commands\makemessages.py
 ", line 317, in gettext_version
     raise CommandError("Unable to get gettext version. Is it installed?")
 CommandError: Unable to get gettext version. Is it installed?
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23788#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.b58b544d3d5e2de6dabba20fe0956ca9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to