#22340: Legacy Table Creation Methods Not Properly Deprecated
---------------------------------+-------------------------------------
Reporter: mlavin | Owner: timgraham
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+-------------------------------------
Changes (by timgraham):
* status: new => assigned
* owner: nobody => timgraham
* has_patch: 0 => 1
Comment:
After looking at this some more, I am not sure there is an actual benefit
or need to move the code that deals with test database creation and to
remove the `DatabaseCreation` class. It seems to me to be a clear
separation of concerns to keep this code where it is (after all, it deals
with database creation).
If that rationale is accepted, the remaining cleanups are:
1. Move the `DatabaseCreation.data_types` properties to `DatabaseWrapper`
as proposed in [https://github.com/django/django/pull/3810 pull request
3810].
2. Remove the legacy SQL generation methods when support for apps without
migrations is dropped in Django 1.9 (done in the commit "Removed obsolete
SQL generation methods." commit of
[https://github.com/django/django/pull/3791 pull request 3791]).
3. Remove the note about `DatabaseCreation` from the deprecation timeline.
This will leave `create_test_db()`, `destroy_test_db()`, and their helper
methods as the only functionality remaining on the `DatabaseCreation`
class.
--
Ticket URL: <https://code.djangoproject.com/ticket/22340#comment:16>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/064.8646f8dc20d4dfc50471a1d91d3103b7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
