#24278: squashmigrations throws ValueError: need more than 1 value to unpack
----------------------------+------------------------------------
     Reporter:  riklaunim   |                    Owner:  knbk
         Type:  Bug         |                   Status:  assigned
    Component:  Migrations  |                  Version:  1.7
     Severity:  Normal      |               Resolution:
     Keywords:              |             Triage Stage:  Accepted
    Has patch:  1           |      Needs documentation:  0
  Needs tests:  0           |  Patch needs improvement:  0
Easy pickings:  0           |                    UI/UX:  0
----------------------------+------------------------------------
Changes (by knbk):

 * has_patch:  0 => 1


Comment:

 PR: https://github.com/django/django/pull/4075

 `MigrationsWriter._serialize_path()` now checks if there is a dot in the
 path, and if there isn't, assumes it is a class in `django.db.migrations`.
 As this module is always imported in generated migrations, I changed the
 imports to an empty dict and the name to `migrations.<ClassName>`.

 This bug was caused by the fact that `Operation.deconstruct()` returns the
 class name as the first value instead of the full import path.

--
Ticket URL: <https://code.djangoproject.com/ticket/24278#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.6aa3954301a88daf1e9091a5f3bf8826%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to