#24406: SelectFilter should use click events instead of href javascript
functions
-------------------------------------+-------------------------------------
Reporter: rjagerman | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Keywords: admin SelectFilter
| javascript
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
SelectFilter uses javascript in an href to handle button behavior:
{{{
<a href="javascript:function(){...}">
}}}
This is problematic if one wishes to customize the widget, since the href
javascript is executed after events are handled. It would be better to use
a click event to handle this type of behavior:
{{{
someElement.addEventListener("click", function() { ... } );
}}}
I have proposed a patch on github:
https://github.com/rjagerman/django/commit/e07a0be20d6da81794eaa5b64c2927cc6c70410d
--
Ticket URL: <https://code.djangoproject.com/ticket/24406>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/052.d27a1483d039e6b18ac5fd1642439791%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
