#24441: core.files.images.get_image_dimensions broken on invalid images
-------------------------------------+-------------------------------------
     Reporter:  artscoop             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Core (Other)         |                  Version:  1.7
     Severity:  Normal               |               Resolution:
     Keywords:  imagefield,          |             Triage Stage:  Accepted
  imagefilefield                     |
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by akulakov):

 It seems more explicit and more proper that an image with unknown
 dimension should have them set as (None, None). For example, if I filter
 out images smaller than 64,64, it would be incorrect to filter out unknown
 sizes.

 If an existing project made an assumption that Pillow is always able to
 calculate image dimensions, that's simply a wrong
 assumption and it's probably reasonable if they work around it or migrate.

 I suggest returning (None, None).

--
Ticket URL: <https://code.djangoproject.com/ticket/24441#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.18eccce21a61c5e2c8d46ed159ff44dc%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to