#24580: Add test for untested condition in admin_list template tag.
-------------------------------------+-------------------------------------
Reporter: liminspace | Owner:
Type: | liminspace
Cleanup/optimization | Status: new
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
What problem are you seeing? I don't think your suggestion is correct as
`f` is a model field instance while `ManyToOneRel` is a "related field" so
I don't think that condition would ever evaluate to `True`. Checking the
coverage report, it appears that branch is being executed, however, no
tests fail when I make the suggested change, so we may want to add some
assertions to the relevant tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/24580#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.91f790da4862d41f1fb59d39b149c7b5%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
