#24987: django.test.client.Client.login() rejects user with is_active=False
-------------------------------------+-------------------------------------
     Reporter:  jdufresne            |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Testing framework    |                  Version:  master
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:
                                     |  Someday/Maybe
    Has patch:  1                    |      Needs documentation:  1
  Needs tests:  1                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by jdufresne):

 > However, your current change is backwards incompatible and will break
 many users' tests. I therefore don't consider it a bug but a feature
 request.
 >
 > One idea that comes to mind, of how to solve the problem in a backwards
 compatible manner, would be a flag on the client check_is_active=True that
 would allow to bypass the check.

 Understood about backwards incompatible concern. I can investigate coding
 this idea if there is agreement that it is the best approach.

 > How about documenting this for now?

 So long as the limitation exists, makes sense. You're diff looks good to
 me.

--
Ticket URL: <https://code.djangoproject.com/ticket/24987#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.fa0bf4cd994a2ce1c3f6bd6263cf50aa%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to