#25064: Join.as_sql() emits invalid SQL if get_joining_columns() returns an 
empty
tuple
-------------------------------------+-------------------------------------
     Reporter:  AlexHill             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  1.8
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by akaariai):

 * stage:  Unreviewed => Accepted


Comment:

 I don't think this should be backpatched as this isn't an omission in a
 new feature (the Join type is completely internal, so its addition doesn't
 count as a new feature).

 Otherwise I don't see any harm in doing the changes.

--
Ticket URL: <https://code.djangoproject.com/ticket/25064#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f72699d4c107e8580811a51e70981fd3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to