#25384: New Migrations Generated with Improperly Sorted Imports
--------------------------------------+------------------------------------
Reporter: jambonrose | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Migrations | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by MarkusH):
* has_patch: 0 => 1
Old description:
> New migration files are generated with the following line of code (found
> in the `django/db/migrations/writer.py` file):
>
> from django.db import models, migrations
>
> Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
> file (for example, for data migrations), it will reorder the import to:
>
> from django.db import migrations, models
>
> It would be great if we were generating properly sorted documents.
New description:
New migration files are generated with the following line of code (found
in the `django/db/migrations/writer.py` file):
{{{
from django.db import models, migrations
}}}
Anytime [https://pypi.python.org/pypi/isort isort] is run on a migration
file (for example, for data migrations), it will reorder the import to:
{{{
from django.db import migrations, models
}}}
It would be great if we were generating properly sorted documents.
--
Comment:
PR: https://github.com/django/django/pull/5274
--
Ticket URL: <https://code.djangoproject.com/ticket/25384#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.1d674bcf6540f0cbbafebca5adb5eea6%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
