#25750: During makemigrations Options._expire_cache takes 30% of the time -------------------------------------+------------------------------------- Reporter: patrys | Owner: patrys Type: | Status: closed Cleanup/optimization | Component: Migrations | Version: 1.8 Severity: Normal | Resolution: fixed Keywords: | Triage Stage: Ready for | checkin Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+------------------------------------- Changes (by Tim Graham <timograham@…>):
* status: new => closed * resolution: => fixed Comment: In [changeset:"7628f87e2b1ab4b8a881f06c8973be4c368aaa3d" 7628f87e]: {{{ #!CommitTicketReference repository="" revision="7628f87e2b1ab4b8a881f06c8973be4c368aaa3d" Fixed #25750 -- Made Options._expire_cache() faster Avoided unnecessary list operations and delattr() calls that result in an exception being raised as it causes call frame reconstruction which is very costly, especially so in a function that is called millions of times. }}} -- Ticket URL: <https://code.djangoproject.com/ticket/25750#comment:7> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/064.9b9b8b140af1613bfaaca2fd1787b617%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.