#25937: Failure when using expressions.DateTime on NULL values and aggregating
-------------------------------------+-------------------------------------
     Reporter:  trecouvr             |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  1.9
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  aggregate timezone   |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by charettes):

 * keywords:  orm aggregate => aggregate timezone
 * stage:  Unreviewed => Accepted


Comment:

 It looks like the
 
[https://github.com/django/django/blob/master/django/db/models/expressions.py#L951-L960
 heuristics to determine whether or not time zone definition are set up
 correctly] conflicts with the use of `DateTime` expressions on nullable
 fields.

 I wonder if `convert_value` has enough context to figure out if its lookup
 is `NULL`able. If it's the case could adjust the heuristics to only thow a
 `ValueError` if its lookup is not nullable and `None` is returned.

--
Ticket URL: <https://code.djangoproject.com/ticket/25937#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.f1c883b11aba4833f12ec4ea16bf7f38%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to