#26204: URLValidator does not accept TLDs with "-"s -------------------------------+-------------------------------------- Reporter: lfaraone | Owner: nobody Type: Bug | Status: new Component: Uncategorized | Version: 1.8 Severity: Normal | Resolution: Keywords: regression | Triage Stage: Unreviewed Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------+-------------------------------------- Description changed by lfaraone:
Old description: > Forwarded from: > http://bugs.debian.org/814372 > > Previous versions of Django allowed for "-"s in the rightmost component > of a hostname. This was tightened in a previous release. While the > [https://github.com/django/django/commit/bc98bc56a52860688ea0ae2ec7b9e59ddb72a811 > case for punycode domains was fixed], there's no technical reason to > disallow them in any part of a hostname component except for at the > beginning or end. > > That is to say: http://ubuntu-mirror.my-tld/ubuntu is flagged as an > invalid URL, even though the DNS has an IP for it, and apt happily > upgrades from the archive mirror that is there. New description: Forwarded from: http://bugs.debian.org/814372 Previous versions of Django allowed for "-"s in the rightmost component of a hostname. This was tightened in a previous release. While the [https://github.com/django/django/commit/bc98bc56a52860688ea0ae2ec7b9e59ddb72a811 case for punycode domains was fixed], there's no technical reason to disallow them in any part of a hostname component except for at the beginning or end. That is to say: http://ubuntu-mirror.my-tld/ubuntu is flagged as an invalid URL, even though the DNS has an IP for it, and apt happily upgrades from the archive mirror that is there. The fix for <https://code.djangoproject.com/ticket/25452#comment:2> appears to be when this regression was introduced. -- -- Ticket URL: <https://code.djangoproject.com/ticket/26204#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/066.641aae75b1f03b45f4e5f934a7c6dd2c%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.