#26253: Deprecation for TemplateResponse and SimpleTemplateResponse accepting
django.template.Template is broken
---------------------------------+------------------------------------
     Reporter:  davidswelt       |                    Owner:  nobody
         Type:  Bug              |                   Status:  new
    Component:  Template system  |                  Version:  1.8
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  1                |      Needs documentation:  0
  Needs tests:  1                |  Patch needs improvement:  0
Easy pickings:  1                |                    UI/UX:  0
---------------------------------+------------------------------------
Changes (by timgraham):

 * severity:  Normal => Release blocker
 * needs_tests:  0 => 1
 * version:  1.9 => 1.8
 * keywords:  Teamplates =>
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Oh, I had trouble understanding your patch and the problem. The issue is
 that the backwards compatibility shim crashes. If you are able to add
 tests for the patch and send a pull request, that would be great.
 {{{
 from django.template import Template
 from django.template.response import TemplateResponse
 from django.http import HttpRequest

 request = HttpRequest()
 content = "…"
 t = Template(content)
 response = TemplateResponse(request, t)
 ...
   File "/home/tim/code/django/django/template/response.py", line 28, in
 __init__
     template = BackendTemplate(template)
 TypeError: __init__() missing 1 required positional argument: 'backend'
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26253#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/068.6daea23b0b309a7bee81f07244712be9%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to