#26328: jsi18n - get_javascript_catalog obscure and hardcoded english -------------------------------------+------------------------------------- Reporter: cristianocca | Owner: nobody Type: Bug | Status: new Component: | Version: 1.9 Internationalization | Severity: Normal | Resolution: Keywords: jsi18n | Triage Stage: | Unreviewed Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by cristianocca): Sorry, first ticket, I guess I lost a lot of information here. With 'obscure' I tried to say that the code is hard to understand, at least for me it is not very obvious why it loads english as default or discards translations if it doesn't find english translations. About backwards compatibility, there will be a difference in what happens if a translation for the requested language is not found, and the default language is not 'en'. Right now if a translation string is not found in the requested language it will fallback to the default language if it has a value defined and if it is not found it will fallback to 'en'. The new behaviour would not fallback to 'en' but rather to the message id, just like the server side version does (although the server side version also has some oddly hardcoded english to not load any fallback if the requested language is english) I can't tell for sure if it will fix #26319 since it is not obvious if he is having an issue due to the english special treatment or due to configuration issues. However with the removed english treatment I can't see any reason of why specific english locales wouldn't be loaded. -- Ticket URL: <https://code.djangoproject.com/ticket/26328#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/070.f1a809fadfea9c3b2fd9279014579828%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.