#25617: Disallow usernames that differ only in case in UserCreationForm
--------------------------------------+------------------------------------
     Reporter:  timgraham             |                    Owner:  nmundar
         Type:  Cleanup/optimization  |                   Status:  assigned
    Component:  contrib.auth          |                  Version:  master
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  1                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  1
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by berkerpeksag):

 * cc: berker.peksag@… (added)


Comment:

 Looking at https://github.com/django/django/pull/5572 again, I'd suggest
 the following API:

 * Adding a `clean_username` method would make `UserCreationForm` less
 subclass friendly. I'd suggest rename `UserCreationForm` to
 `BaseUserCreationForm` and document it as a preferred way to extend user
 creation form
 * Add a `clean_username` method to `UserCreationForm` (it will be a
 subclass of `BaseUserCreationForm`)

 Thoughts?

--
Ticket URL: <https://code.djangoproject.com/ticket/25617#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.7e89f60e46ad8eb9b952060b4f804b25%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to