#26520: Undo #24621 to make session.pop raise a KeyError again
----------------------------------+--------------------------------------
     Reporter:  tuky              |                    Owner:  nobody
         Type:  Bug               |                   Status:  new
    Component:  contrib.sessions  |                  Version:  1.9
     Severity:  Normal            |               Resolution:
     Keywords:                    |             Triage Stage:  Unreviewed
    Has patch:  1                 |      Needs documentation:  0
  Needs tests:  0                 |  Patch needs improvement:  0
Easy pickings:  1                 |                    UI/UX:  0
----------------------------------+--------------------------------------

Comment (by tuky):

 Thanks for your feedback. Do you just propose to further change the docs
 or also even the code? I think the `session.pop` wrapper should have a
 signature as close to the original `dict.pop` as possible:

 {{{
 >>> {}.pop("key", default="fallback")
 Traceback (most recent call last):
   File "<bpython-input-6>", line 2, in <module>
     {}.pop("key", default="fallback")
 TypeError: pop() takes no keyword arguments
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26520#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.b5d7ed9e1fb217f59c09dabef9bb7130%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to