#26586: makemigrations does not detect custom field subclassing change -------------------------------------+------------------------------------- Reporter: tuffnatty | Owner: baylee Type: Bug | Status: assigned Component: Migrations | Version: 1.9 Severity: Normal | Resolution: Keywords: migrations, custom | Triage Stage: Accepted fields | Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by baylee): After discussion with Markus at PyCon sprints 2016: This isn't possible. The closest we get is [https://github.com/django/django/blob/master/django/db/migrations/autodetector.py#L879 here], where we could add a check for `get_internal_type()` of the two fields. But that won't work because the old state and new state are dynamically generated from the field definition in the migration files. The only way to handle this would be if we saved internal type as part of the migrations. Propose closing this in favor of adding documentation in #26702 -- Ticket URL: <https://code.djangoproject.com/ticket/26586#comment:5> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.6426176abbafa781e041062f21c86d77%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.