#25415: Make DiscoverRunner run system checks
-----------------------------------+------------------------------------
Reporter: adamchainz | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------------------
Comment (by adamchainz):
I've corrected all the check errors exception from some E340 errors (check
added June 3 in #12810):
{{{
django.core.management.base.SystemCheckError: SystemCheckError: System
check identified some issues:
ERRORS:
model_options.Article.authors: (fields.E340) The field's intermediary
table 'model_options_articleref_authors' clashes with the table name of
'model_options.ArticleRef.authors'.
model_options.Article.reviewers: (fields.E340) The field's intermediary
table 'model_options_articleref_reviewers' clashes with the table name of
'model_options.ArticleRef.reviewers'.
model_options.ArticleRef.authors: (fields.E340) The field's intermediary
table 'model_options_articleref_authors' clashes with the table name of
'model_options.Article.authors'.
model_options.ArticleRef.reviewers: (fields.E340) The field's intermediary
table 'model_options_articleref_reviewers' clashes with the table name of
'model_options.Article.reviewers'.
unmanaged_models.C01.mm_a: (fields.E340) The field's intermediary table
'd01' clashes with the table name of 'unmanaged_models.Intermediate'.
unmanaged_models.C02.mm_a: (fields.E340) The field's intermediary table
'd01' clashes with the table name of 'unmanaged_models.C01.mm_a'.
}}}
In the first case the test models seem to hack their M2M fields to use the
same tables on purpose (??). In the second case the tests are re-using the
tables for unmanaged models on purpose.
For the latter case, I can imagine that E340 should ignore unmanaged
models, but I'm not 100% sure. For the former though, whether it's the
`model_options` tests that are 'wrong', or the check, I don't think I'm
qualified to know :/
--
Ticket URL: <https://code.djangoproject.com/ticket/25415#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.c946eac663bd6f7e1c3d5f635c57bf95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
