#27074: connection.is_usable() raises AttributeError after the connection is 
closed
-------------------------------------+-------------------------------------
     Reporter:  cjerdonek            |                    Owner:  nobody
         Type:                       |                   Status:  new
  Cleanup/optimization               |
    Component:  Database layer       |                  Version:  1.10
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by cjerdonek):

 I believe the trickiest part of the patch will be handling / dealing with
 the fact that there are multiple backend implementations of `is_usable()`.

 Ideally, I think one would want to put the logic in the base
 implementation and call `super()` as appropriate. Alternatively, it looks
 like it would be sufficient to include the logic in all three non-trivial
 implementations: mysql, oracle, and postgresql. Those each look like the
 following:

 {{{#!python
 def is_usable(self):
     try:
         self.connection.ping()
     except Database.Error:
         return False
     else:
         return True
 }}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27074#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e59269861825cf608740e4e6755f0a4e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to