#19705: CommonMiddleware handles If-None-Match incorrectly -------------------------------------+------------------------------------- Reporter: Aymeric Augustin | Owner: Denis | Cornehl Type: Bug | Status: closed Component: HTTP handling | Version: master Severity: Normal | Resolution: fixed Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -------------------------------------+-------------------------------------
Comment (by Kevin Christopher Henry): [https://github.com/django/django/pull/7378 PR] for having GZipMiddleware set gzip modification times to 0. I'm not aware of any downside, and the advantage is that `ConditionalGetMiddleware` will work (that is, produce 304 Not Modified responses) on gzipped content (e.g. if the order of the middlewares is reversed, or if the `gzip_page()` view decorator is used). This usage is allowed by the specification ("MTIME = 0 means no time stamp is available", Section 2.3.1 of [https://tools.ietf.org/html/rfc1952 RFC 1952]) and is in common use (for example, Java's `GZipOutputStream` sets the MTIME to 0). -- Ticket URL: <https://code.djangoproject.com/ticket/19705#comment:19> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/067.7ffd275a8e832d1694b7d1dcb77307e3%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.