#27370: Django's Select widget adds a required="required" attribute, even if
created with empty_label=True
-------------------------------------+-------------------------------------
Reporter: alexpirine | Owner: Josef
Type: | Rousek
Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
HTML,Select,wdiget,ModelChoiceField|
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Josef Rousek):
Replying to [comment:10 alexpirine]:
> I reviewed the code:
>
> The overall logic and tests seem to be correct, except in case of an
empty <select>.
>
> But I can not make a full judgment about the code, since I lack the
understanding of some parts of `widgets.py`. For instance I didn't know
anything about the `renderer` attribute (I still can not find it in
documentation).
Thanks for review! I'll fix those issues.
--
Ticket URL: <https://code.djangoproject.com/ticket/27370#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.41dc84682aba4fadb9b3d2b331b6e6bf%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
