#27842: class GenericSitemap doesn't handle "protocol" in __init__
-------------------------------------+-------------------------------------
     Reporter:  chex                 |                    Owner:  chex
         Type:  New feature          |                   Status:  assigned
    Component:  contrib.sitemaps     |                  Version:  1.10
     Severity:  Normal               |               Resolution:
     Keywords:  sitemaps             |             Triage Stage:  Accepted
  genericsitemap                     |
    Has patch:  1                    |      Needs documentation:  1
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Tim Graham):

 And documentation? Please update the ticket flags when you update the
 patch. It looks like the tests are testing more than just what's changed.
 It's fine to increase test coverage but please do it in a separate commit
 (perhaps a separate PR that precedes this one).

--
Ticket URL: <https://code.djangoproject.com/ticket/27842#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.c9caab7710f77912dd6eb6157200a8de%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to