#29468: Improve Form Field declaration of widget `attrs`.
-------------------------------------+-------------------------------------
Reporter: Ivan Muller | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: wontfix
Keywords: Field Widget html | Triage Stage:
attrs | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* resolution: => wontfix
Old description:
> Hi guys, I want to improve the way of declear html attrs into a
> Fields With out declaring the default widget again.
>
> {{{
> example:
> class ProfileForm(forms.ModelForm):
> class Meta:
> model = Profile
> full_name = forms.CharField(widget=forms.TextInput(attrs={'class':
> Anyclass',}))
> }}}
>
>
> As Field documentaiton say into the init:
> """Each Field has a default Widget that it'll use if you don't specify
> this. n most cases, the default widget is TextInput:"""
> Woudl be god to declare it as
>
> {{{
> full_name = forms.CharField(widget_attrs={'class': Anyclass',})
> }}}
New description:
Hi guys, I want to improve the way of declear html attrs into a Fields
With out declaring the default widget again.
Example:
{{{
class ProfileForm(forms.ModelForm):
class Meta:
model = Profile
full_name = forms.CharField(widget=forms.TextInput(attrs={'class':
Anyclass',}))
}}}
As Field documentaiton say into the init:
"""Each Field has a default Widget that it'll use if you don't specify
this. n most cases, the default widget is TextInput:"""
Woudl be god to declare it as
{{{
full_name = forms.CharField(widget_attrs={'class': Anyclass',})
}}}
--
Comment:
Hi @mullerivan,
The docs for [https://docs.djangoproject.com/en/2.0/ref/forms/widgets
/#styling-widget-instances Styling widget instances] give three
approaches. The one you'd like to avoid is just the first.
In your case, I guess I'd recommend the second approach, to adjust the
widget attrs inline in the form definition:
{{{
class ProfileForm(forms.ModelForm):
full_name = forms.CharField()
full_name.widget.attrs.update({'class': 'Anyclass',})
class Meta:
model = Profile
}}}
Given that multiple options already exist, adding yet another keyword
argument is not going to be worth it on balance.
(The benefit won't justify the extra API surface area.)
Also see the `ModelForm` docs on
[https://docs.djangoproject.com/en/2.0/topics/forms/modelforms
/#overriding-the-default-fields Overriding default fields]. If it's API
**you** really want in **your project** there's nothing to stop you
creating a base form class or mixin the takes an additional
`extra_widget_attrs` and sets that appropriately during `__init__()`, as a
generalisation of the third strategy outlined in the ''Styling widget
instances'' docs linked above.
--
Ticket URL: <https://code.djangoproject.com/ticket/29468#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.f1872bd74b5369ff1a7c5b9160d1a47d%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
