#29152: Allow more control over ArgumentParser initialization in management
commands
-------------------------------------+-------------------------------------
     Reporter:  Dmitry               |                    Owner:
         Type:                       |  humbertotm
  Cleanup/optimization               |                   Status:  assigned
    Component:  Core (Management     |                  Version:  2.0
  commands)                          |
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by humbertotm):

 Replying to [comment:7 Dmitry]:
 > Replying to [comment:5 Tom Forbes]:
 > > The create_parser method could just pass in all kwargs to
 CommandParser, rather than having a parser_kwargs instance variable?
 > >
 > >
 > > {{{#!python
 > > def create_parser(self, **kwargs):
 > >     return super().create_parser(my_custom_arg=123)
 > >
 > > # In BaseCommand
 > > def create_parser(self, **kwargs):
 > >     kwargs.setdefault('description', ...)
 > >     return CommandParser(self, **kwargs)
 > > }}}
 > >
 > > Might be a bit more flexible
 > I agree, this looks better.

 By the looks of this, I am guessing that every call to this method in the
 code base would have to be modified to fit this new signature, right?

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29152#comment:9>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.1c0a948a7e5905808f288d7a4c55af7f%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to