#29613: --keepdb flag for postgresql does not work with some database error 
codes
-------------------------------------+-------------------------------------
     Reporter:  Paul McDermott       |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Database layer       |                  Version:  2.0
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  postgres, --keepdb   |             Triage Stage:
                                     |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Paul McDermott):

 The following modification to _execute_create_test_db() got the --keepdb
 flag working again for me on Web Faction


 {{{
 def _execute_create_test_db(self, cursor, parameters, keepdb=False):
     try:
         super()._execute_create_test_db(cursor, parameters, keepdb)
     except Exception as e:
         allowed_codes = [errorcodes.DUPLICATE_DATABASE,
 errorcodes.INSUFFICIENT_PRIVILEGE]
         if getattr(e.__cause__, 'pgcode', '') in allowed_codes:
             # All errors except "database already exists" cancel tests.
             self.log('Got an error creating the test database: %s' % e)
             sys.exit(2)
         elif not keepdb:
             # If the database should be kept, ignore "database already
             # exists".
             raise e
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29613#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.5e257180ff8b357f32ffce35f0423868%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to