#29829: Clean `_simple_domain_name_validator` function in django/contrib/sites/models.py ------------------------------------------------+------------------------ Reporter: Hasan Ramezani | Owner: nobody Type: Cleanup/optimization | Status: new Component: Core (Other) | Version: 2.1 Severity: Normal | Keywords: Triage Stage: Unreviewed | Has patch: 1 Needs documentation: 0 | Needs tests: 0 Patch needs improvement: 0 | Easy pickings: 0 UI/UX: 0 | ------------------------------------------------+------------------------ There is an `if block` in `_simple_domain_name_validator` function that seems there is no need for them because `domain` field in `Site` model is `not null`.
{{{ if not value: return }}} I am going to remove them. -- Ticket URL: <https://code.djangoproject.com/ticket/29829> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To post to this group, send email to django-updates@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/django-updates/052.a7bc52ae6dcfb2582d61da0f495b6e3e%40djangoproject.com. For more options, visit https://groups.google.com/d/optout.