#23829: Allow customizing the `ping_google` URL
-------------------------------------+-------------------------------------
Reporter: Julian Wachholz | Owner: Sanyam
Type: | Khurana
Cleanup/optimization | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: sitemaps, | Triage Stage: Accepted
ping_google |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
Reviewing, the PR looks almost ready to go.
Posting here for input: it's late-2018, I propose the `is_secure` flag
default to `True`, i.e. we default to `https://...`.
* This would be a slight breaking change for anyone using this to send
`http` URLs — they'd need to pass the `is_secure` flag.
* But, presumably the vast majority (and best practice now) wouldn't need
to set the flag at all. (On balance less key-strokes)
Thoughts/objections?
--
Ticket URL: <https://code.djangoproject.com/ticket/23829#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/061.50ed4fb96cdbc19b2a02655f1e3d2f79%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.
