#30259: Support the use of admin_order_field on properties in the admin.
---------------------------------+----------------------------------------
     Reporter:  Tobias Wiese     |                    Owner:  Jani Tiainen
         Type:  New feature      |                   Status:  new
    Component:  contrib.admin    |                  Version:  master
     Severity:  Release blocker  |               Resolution:
     Keywords:                   |             Triage Stage:  Accepted
    Has patch:  0                |      Needs documentation:  0
  Needs tests:  0                |  Patch needs improvement:  0
Easy pickings:  0                |                    UI/UX:  0
---------------------------------+----------------------------------------
Changes (by Tim Graham):

 * status:  closed => new
 * severity:  Normal => Release blocker
 * easy:  1 => 0
 * has_patch:  1 => 0
 * resolution:  fixed =>
 * stage:  Ready for checkin => Accepted


Comment:

 A selenium test fails after the patch:
 `admin_views.tests.SeleniumTests.test_list_editable_raw_id_fields`:
 {{{
 Traceback (most recent call last):
   File "/home/tim/code/django/django/core/handlers/exception.py", line 34,
 in inner
     response = get_response(request)
   File "/home/tim/code/django/django/core/handlers/base.py", line 145, in
 _get_response
     response = self.process_exception_by_middleware(e, request)
   File "/home/tim/code/django/django/core/handlers/base.py", line 143, in
 _get_response
     response = response.render()
   File "/home/tim/code/django/django/template/response.py", line 106, in
 render
     self.content = self.rendered_content
   File "/home/tim/code/django/django/template/response.py", line 83, in
 rendered_content
     content = template.render(context, self._request)
   File "/home/tim/code/django/django/template/backends/django.py", line
 61, in render
     return self.template.render(context)
   File "/home/tim/code/django/django/template/base.py", line 171, in
 render
     return self._render(context)
   File "/home/tim/code/django/django/test/utils.py", line 95, in
 instrumented_test_render
     return self.nodelist.render(context)
   File "/home/tim/code/django/django/template/base.py", line 937, in
 render
     bit = node.render_annotated(context)
   File "/home/tim/code/django/django/template/base.py", line 904, in
 render_annotated
     return self.render(context)
   File "/home/tim/code/django/django/template/loader_tags.py", line 150,
 in render
     return compiled_parent._render(context)
   File "/home/tim/code/django/django/test/utils.py", line 95, in
 instrumented_test_render
     return self.nodelist.render(context)
   File "/home/tim/code/django/django/template/base.py", line 937, in
 render
     bit = node.render_annotated(context)
   File "/home/tim/code/django/django/template/base.py", line 904, in
 render_annotated
     return self.render(context)
   File "/home/tim/code/django/django/template/loader_tags.py", line 150,
 in render
     return compiled_parent._render(context)
   File "/home/tim/code/django/django/test/utils.py", line 95, in
 instrumented_test_render
     return self.nodelist.render(context)
   File "/home/tim/code/django/django/template/base.py", line 937, in
 render
     bit = node.render_annotated(context)
   File "/home/tim/code/django/django/template/base.py", line 904, in
 render_annotated
     return self.render(context)
   File "/home/tim/code/django/django/template/loader_tags.py", line 62, in
 render
     result = block.nodelist.render(context)
   File "/home/tim/code/django/django/template/base.py", line 937, in
 render
     bit = node.render_annotated(context)
   File "/home/tim/code/django/django/template/base.py", line 904, in
 render_annotated
     return self.render(context)
   File "/home/tim/code/django/django/template/loader_tags.py", line 62, in
 render
     result = block.nodelist.render(context)
   File "/home/tim/code/django/django/template/base.py", line 937, in
 render
     bit = node.render_annotated(context)
   File "/home/tim/code/django/django/template/base.py", line 904, in
 render_annotated
     return self.render(context)
   File "/home/tim/code/django/django/contrib/admin/templatetags/base.py",
 line 33, in render
     return super().render(context)
   File "/home/tim/code/django/django/template/library.py", line 214, in
 render
     _dict = self.func(*resolved_args, **resolved_kwargs)
   File
 "/home/tim/code/django/django/contrib/admin/templatetags/admin_list.py",
 line 332, in result_list
     headers = list(result_headers(cl))
   File
 "/home/tim/code/django/django/contrib/admin/templatetags/admin_list.py",
 line 133, in result_headers
     admin_order_field = getattr(attr.fget, 'admin_order_field')
 AttributeError: 'function' object has no attribute 'admin_order_field'
 }}}

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30259#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.4d61963d54b7b41b068f9e2e92598b98%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Reply via email to