#30870: "migrate --plan" outputs "IRREVERSIBLE" on RunPython operations without
docstrings.
-------------------------------------+-------------------------------------
Reporter: Kyle Dickerson | Owner: felixxm
Type: Bug | Status: assigned
Component: Core (Management | Version: 2.2
commands) |
Severity: Release blocker | Resolution:
Keywords: migrate | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by felixxm):
Replying to [comment:6 Kyle Dickerson]:
> The current code ''should'' have that behavior because, with this bug
fix, `action` should only be `None` on line 356 if we set it based on
either `reverse_code` or `reverse_sql` (since `code` and `sql` are
required attributes of their respective operations), but it's not an
explicit restriction in the current form. It would certainly be more
readable to make that restriction explicit (e.g., in my proposed broader
refactor).
`code` and `sql` are required attributes but they can be empty,
nevertheless I agree that `IRREVERSIBLE` should be displayed on for
`backwards`.
--
Ticket URL: <https://code.djangoproject.com/ticket/30870#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.396e687c84725ab456879db23a03ba71%40djangoproject.com.
