#31698: Remove database backend Operations.autoinc_sql
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: nobody
Johnson |
Type: | Status: new
Cleanup/optimization |
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Adam (Chainz) Johnson:
Old description:
> This was added in 924a89e135fe54bc7622aa6f03405211e75c06e9 to support
> Oracle. However 924a89e135fe54bc7622aa6f03405211e75c06e9 reimplemented
> the Oracle autoincrement keys without `autoinc_sql`.
>
> I checked two popular third party backends and they aren't using it:
>
> * django-mssql-backend: https://github.com/ESSolutions/django-mssql-
> backend/blob/master/sql_server/pyodbc/operations.py
> * django-cockroachdb: https://github.com/cockroachdb/django-
> cockroachdb/blob/master/django_cockroachdb/operations.py
New description:
This was added in 38b5d7f23d8f7a39646a9b298f10941a70585031 and added to
the migrations schema editor in 924a89e135fe54bc7622aa6f03405211e75c06e9.
It was only ever used for Oracle support.
924a89e135fe54bc7622aa6f03405211e75c06e9 reimplemented Oracle
autoincrement keys without `autoinc_sql`, so it has no use in Django core
any more.
I checked two popular third party backends and they aren't using it:
* django-mssql-backend: https://github.com/ESSolutions/django-mssql-
backend/blob/master/sql_server/pyodbc/operations.py
* django-cockroachdb: https://github.com/cockroachdb/django-
cockroachdb/blob/master/django_cockroachdb/operations.py
--
--
Ticket URL: <https://code.djangoproject.com/ticket/31698#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/068.f3d1bd2096f21a78e952ef4321fa556e%40djangoproject.com.
