#31765: schema.tests.SchemaTests.test_db_table fails on MacOS
-------------------------------+------------------------------------
     Reporter:  Tom Forbes     |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  Uncategorized  |                  Version:  master
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Accepted
    Has patch:  1              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  0
-------------------------------+------------------------------------

Comment (by Tom Forbes):

 This is the output from the `sqlite3` CLI tool, running the MacOS sqlite3:

 {{{
 BUG_COMPATIBLE_20160819
 COMPILER=clang-11.0.3
 DEFAULT_CACHE_SIZE=2000
 DEFAULT_CKPTFULLFSYNC
 DEFAULT_JOURNAL_SIZE_LIMIT=32768
 DEFAULT_PAGE_SIZE=4096
 DEFAULT_SYNCHRONOUS=2
 DEFAULT_WAL_SYNCHRONOUS=1
 ENABLE_API_ARMOR
 ENABLE_COLUMN_METADATA
 ENABLE_DBSTAT_VTAB
 ENABLE_FTS3
 ENABLE_FTS3_PARENTHESIS
 ENABLE_FTS3_TOKENIZER
 ENABLE_FTS4
 ENABLE_FTS5
 ENABLE_JSON1
 ENABLE_LOCKING_STYLE=1
 ENABLE_PREUPDATE_HOOK
 ENABLE_RTREE
 ENABLE_SESSION
 ENABLE_SNAPSHOT
 ENABLE_SQLLOG
 ENABLE_UNKNOWN_SQL_FUNCTION
 ENABLE_UPDATE_DELETE_LIMIT
 HAVE_ISNAN
 MAX_LENGTH=2147483645
 MAX_MMAP_SIZE=1073741824
 MAX_VARIABLE_NUMBER=500000
 OMIT_AUTORESET
 OMIT_LOAD_EXTENSION
 STMTJRNL_SPILL=131072
 THREADSAFE=2
 USE_URI
 }}}

 I can't see anything there that would be suitable to to safely detect
 MacOS bundled SQLite. We could maybe branch off "COMPILER" and maybe
 "BUG_COMPATIBLE_20160819" but it seems equally as dirty.

 So, just to re-iterate the point above: This code path should only be
 called during migrations. While feature detection is definitely slower, in
 this case I feel that it's warranted - looking through the git history for
 this specific flag the version range has been changed previously, and it's
 not in the hot path of any requests and shouldn't slow down startup.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/31765#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/061.baa06f1a0484326e501403ffb0e29c68%40djangoproject.com.

Reply via email to