#30427: Descriptors not accessible for inherited models.
-------------------------------------+-------------------------------------
     Reporter:  Jarek Glowacki       |                    Owner:  Jarek
                                     |  Glowacki
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  master
  (models, ORM)                      |
     Severity:  Normal               |               Resolution:
     Keywords:  inherited            |             Triage Stage:  Accepted
  descriptor deferred                |
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):

 * needs_better_patch:  0 => 1


Comment:

 Reviewing **again** the change here does seem OK.

 * Apparent MRO is changed to the "strictly-depth-first" ordering.
 * That's OK, because the case it affects is previously ruled-out by the
 check framework.

 [https://github.com/django/django/pull/11337#pullrequestreview-454009820
 See PR for longer comment].

 Tests need a little clarification, just to document the exact behaviour
 clearly, but with that in place I think this should be good to go.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/30427#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4ad8c73e75b1499d1911f5d13e29dd60%40djangoproject.com.

Reply via email to