#24782: Add TestCase.assertFormValid
-----------------------------------+---------------------------------------
Reporter: Marc Tamlyn | Owner: David Smith
Type: New feature | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: wontfix
Keywords: forms | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------------+---------------------------------------
Changes (by felixxm):
* status: assigned => closed
* resolution: => wontfix
* stage: Accepted => Unreviewed
Comment:
After detailed analysis provided by David we decided to close this as
`wontfix`:
- expecting a user to pass in all the requirements to pass the
`ValidationError` equality test is too hard to be useful,
- the currently proposed `code` method isn't that robust, there may be too
many caveats for it to be useful, e.g. custom user errors generated where
passwords don't match are unlikely to have a code passed into the
`ValidationError`,
- if it's just pass/fail that isn't much benefit from
`self.assertIs(form.is_valid(), True)`,
In the end, this isn't worth adding extra functions.
--
Ticket URL: <https://code.djangoproject.com/ticket/24782#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/066.d1677fa81b17af6393c62cb7c54ad4c1%40djangoproject.com.
