#29606: Validate the type of ALLOWED_HOSTS
-------------------------------------+-------------------------------------
     Reporter:  rafis                |                    Owner:  Octavio
                                     |  Peri
         Type:  New feature          |                   Status:  assigned
    Component:  Core (System         |                  Version:  master
  checks)                            |
     Severity:  Normal               |               Resolution:
     Keywords:  allowed_hosts        |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  1
Easy pickings:  1                    |                    UI/UX:  0
-------------------------------------+-------------------------------------

Comment (by Marius Räsener):

 Wouldn't it be best to check if the entries in `ALLOWED_HOSTS` are
 actually valid hosts?
 So either IPv4/IPv6 Addresses or some dot separated string with valid
 characters.

 Maybe I didn't understand how the bug appeared. Or was it something like:
 {{{
 # wrong
 ALLOWED_HOSTS="127.0.0.1"
 }}}
 vs.
 {{{
 ALLOWED_HOSTS=["127.0.0.1",]
 }}}
 also, doesn't work a tuple too?

 thx for any hints giving me a better understanding...

-- 
Ticket URL: <https://code.djangoproject.com/ticket/29606#comment:12>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/063.c1151a84dce450d524ecee51bd9e2468%40djangoproject.com.

Reply via email to