#32397: django-admin start[project|app] doesn't send proper user agent header
when
HTTP(S) url is sent.
-------------------------------------+-------------------------------------
Reporter: rsp2k | Owner: (none)
Type: | Status: closed
Cleanup/optimization |
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson):
* status: new => closed
* type: New feature => Cleanup/optimization
* resolution: => needsinfo
* needs_tests: 0 => 1
Comment:
Hi rsp2k.
I'm inclined to accept this — no problem setting the User-Agent.
Initially though I'm going to close as `needsinfo` — that info being,
**are you up for finishing this**?
I see you removed your assignment, but the patch needs tests. Specifically
they could go in `django/tests/admin_scripts/tests.py` in the
`StartProject` and `StartApp` classes.
If so can you add the tests, [https://github.com/django/django/pulls open
a PR on GitHub], re-open the ticket, and assign yourself again?
Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/32397#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/063.17816ec0dae93f03f0b0076cf7db9121%40djangoproject.com.
