#32800: CsrfViewMiddleware unnecessarily masks CSRF cookie
--------------------------------------+------------------------------------
Reporter: Chris Jerdonek | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: CSRF | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Chris Jerdonek):
> Ok, then lets make sure we have that situation tested as well and I
think we can go ahead with it.
I posted a preliminary PR for the purpose only of adding additional tests:
https://github.com/django/django/pull/14485
The PR includes tests of all combinations of masked and unmasked secrets,
and masked and unmasked tokens (both via `POST` and the `X-CSRFToken`
header). See `test_masked_unmasked_combinations()` in both
`CsrfViewMiddlewareTests` and `CsrfViewMiddlewareUseSessionsTests`.
--
Ticket URL: <https://code.djangoproject.com/ticket/32800#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/067.33b968b1834b9e73c2f443b07df519cd%40djangoproject.com.
