#32850: Sitemap.items() gets called several times: Fix or document?
--------------------------------------+------------------------------------
     Reporter:  Thomas Güttler        |                    Owner:  nobody
         Type:  Cleanup/optimization  |                   Status:  new
    Component:  Documentation         |                  Version:  3.2
     Severity:  Normal                |               Resolution:
     Keywords:                        |             Triage Stage:  Accepted
    Has patch:  0                     |      Needs documentation:  0
  Needs tests:  0                     |  Patch needs improvement:  0
Easy pickings:  0                     |                    UI/UX:  0
--------------------------------------+------------------------------------
Changes (by Carlton Gibson):

 * type:  Uncategorized => Cleanup/optimization
 * component:  Uncategorized => Documentation
 * stage:  Unreviewed => Accepted


Comment:

 Hi Thomas, thanks.

 > The ​Sitemap.items() method might get called several times (if you
 generate several pages in batch)

 I don't see this as any different from (e.g.) a paginated `ListView`, i.e.
 not really as problematic.

 If you wanted to add `paginator` to the reference docs though, with a
 comment such as ''You may wish to override as a cached property this if
 you are generating multiple sitemap pages in a batch'' (or something) I
 guess that wouldn't hurt.

-- 
Ticket URL: <https://code.djangoproject.com/ticket/32850#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e9396fefa9c8bbfa23233d62d6739438%40djangoproject.com.

Reply via email to