#13217: LocaleMiddleware breaks caching. (Vary: Cookie)
-------------------------------------+-------------------------------------
Reporter: harm | Owner: nobody
Type: Uncategorized | Status: closed
Component: Uncategorized | Version: 1.2-beta
Severity: Normal | Resolution: fixed
Keywords: session accessed | Triage Stage:
vary cookie | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jerome Leclanche):
Replying to [comment:14 Aymeric Augustin]:
> If you're using `i18n_patterns` (introduced in Django 1.4) and the URL
contains a language prefix, `get_language_from_request` will select the
active language without reading the session.
>
> So, in practice, this is fixed.
@Aymeric Augustin -- I believe there's an unhandled edge case if
i18n_patterns receives ``prefix_default_language=False``: accept-language
will still be set, even though the language of the page in question is
static. I can't investigate more right now, and I know that
``prefix_default_language`` is fairly new, but leaving this here for
posterity.
--
Ticket URL: <https://code.djangoproject.com/ticket/13217#comment:17>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/062.562029679d9ff6df41bf04d6e5e02d7e%40djangoproject.com.
